Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/http): websocket upgrade header check #11830

Merged
merged 2 commits into from
Aug 24, 2021
Merged

fix(ext/http): websocket upgrade header check #11830

merged 2 commits into from
Aug 24, 2021

Conversation

galiazzi
Copy link
Contributor

Fixes #11747

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bartlomieju
bartlomieju reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @galiazzi, any chance we could get a test exercising this change?

lucacasonato
lucacasonato reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have one small change request.

ext/http/01_http.js Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @galiazzi

@bartlomieju bartlomieju merged commit 873cce2 into denoland:main Aug 24, 2021
@galiazzi galiazzi deleted the fix/ws-upgrade-header branch August 25, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lowercase on websocket upgrade header check
4 participants
@galiazzi @CLAassistant @lucacasonato @bartlomieju