Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove windows-only panic when calling Deno.kill #11948

Merged
merged 5 commits into from
Sep 7, 2021
Merged

fix: remove windows-only panic when calling Deno.kill #11948

merged 5 commits into from
Sep 7, 2021

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 7, 2021

Further fixes #11939

@dsherret dsherret mentioned this pull request Sep 7, 2021
Merged
piscisaureus
piscisaureus reviewed Sep 7, 2021
View reviewed changes
runtime/ops/signal.rs Outdated Show resolved Hide resolved
piscisaureus
piscisaureus approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret merged commit e3a484a into denoland:main Sep 7, 2021
@dsherret dsherret deleted the remove-windows-panic branch September 7, 2021 22:45
@lucacasonato lucacasonato mentioned this pull request Sep 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows signal stubs are panicking
2 participants
@dsherret @piscisaureus