Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): add HkdfParams and Pkdf2Params types #11991

Merged
merged 3 commits into from
Sep 12, 2021
Merged

fix(ext/crypto): add HkdfParams and Pkdf2Params types #11991

merged 3 commits into from
Sep 12, 2021

Conversation

littledivy
Copy link
Member

whoops! (again 🤕)

ry
ry reviewed Sep 12, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @littledivy

Although we have all these WPT tests, having some basic TypeScript tests is still useful for things like this. Could you please add a v small test?

lucacasonato
lucacasonato approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lucacasonato lucacasonato merged commit 0520ae6 into denoland:main Sep 12, 2021
@littledivy littledivy deleted the fix/hkdf_types branch September 13, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @ry @lucacasonato