feat: add --no-check=remote flag
#12766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 28, 2021
Comment on lines
+2364
to
+2371
| if let Some(cache_type) = matches.value_of("no-check") { | ||
| match cache_type { | ||
| "remote" => flags.check = CheckFlag::Local, | ||
| _ => debug!( | ||
| "invalid value for 'no-check' of '{}' using default", | ||
| cache_type | ||
| ), | ||
| } |
There was a problem hiding this comment.
Maybe use possible_values in flag definition instead of manually parsing? Or does it not play nicely with "no value"?
bartlomieju
approved these changes
Nov 28, 2021
There was a problem hiding this comment.
LGTM, I'm in favor of this change, I agree it's better approach than #12726
kitsonk
force-pushed
the
kitsonk/issue11970
branch
from
38e6f91
to
f2d1fde
Compare
|
Would be good to get @lucacasonato's view on this, since it was his idea. |
|
Yeah, sorry. Will review Monday morning! |
lucacasonato
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Tried it out locally, and this works great. Thanks @kitsonk!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11970
This is an MVP feature that allows
--no-check=remoteto be passed on the command line, and will cause diagnostics related to remote modules to be "filtered" and not cause the process to terminate.It uses a simplistic concept of remote modules at this point, which is those diagnostics where the specifier for the diagnostics starts with
http. This means type errors in a remote module that import adataURL would not be covered. This would require an increased complexity of determining the importer of a specifier and determining if that importer is a remote module or not.Also realised that I currently haven't included file names that start with
assetordeno, which might also make sense, as users can't "control" errors from those locations.If we ever considered this the default behaviour, we might want to consider a warning indicating that some diagnostics were filtered out and to use a different flag to have them displayed.