-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext/webstorage): make getOwnPropertyDescriptor
with symbol return undefined
#13348
fix(ext/webstorage): make getOwnPropertyDescriptor
with symbol return undefined
#13348
Conversation
probably should add a wpt for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yeah, I would raise an issue on the WPT tests for it.
deno/ext/webstorage/01_webstorage.js Lines 133 to 136 in 79b698f
It seems Symbol('foo') in localStorage would throw same error
|
@crowlKats can this be landed for 1.19? |
@bartlomieju I need to look into this again; functionality wise its correct, but no tests currently so i'd like to hold off for a later release |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Luca Casonato <hello@lcas.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crowlKats can you add a test?
Closes #13347