-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/web): EventSource #14730
feat(ext/web): EventSource #14730
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
# Conflicts: # runtime/js/99_main.js # tools/wpt/expectation.json
@crowlKats When will this be merged? I've been waiting for EventSource for almost a year now |
@titomitto there are a bunch of tests that are not passing, but this is currently not a priority for me to work on |
would love to have this feature since pocketbase uses SSE's for realtime database updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires rebase and presumably work to get the WPT tests for EventSource working.
@aapoalas Are you working on this PR? Would love to see this in Deno. |
This would be so useful API to have out-of-the-box, like in the browser. |
# Conflicts: # ext/fetch/26_fetch.js # ext/fetch/27_eventsource.js # ext/fetch/lib.rs # runtime/js/98_global_scope.js
Where are we at with this one, anyway i can jump in and help with this? In need of this i think. |
Signed-off-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #10298