feat(npm): add flag for creating and resolving npm packages to a local node_modules folder #15971
Conversation
That's right, I think we should consider adding |
| @@ -294,6 +324,60 @@ pub async fn remove_dir_all_if_exists(path: &Path) -> std::io::Result<()> { | |||
| } | |||
| } | |||
|
|
|||
| /// Copies a directory to another directory. | |||
| /// | |||
| /// Note: Does not handle symlinks. | |||
There was a problem hiding this comment.
Should it handle symlinks at some point?
There was a problem hiding this comment.
Maybe. For now it doesn't because it's not necessary for npm packages from my understanding.
| let testdata_dir = testdata_path(); | ||
| let args = args | ||
| .iter() | ||
| .map(|arg| arg.replace("$TESTDATA", &testdata_dir.to_string_lossy())) | ||
| .collect::<Vec<_>>(); |
|
While an env var might be more appropriate in the sense that typically |
dsherret
changed the title
--local-npm flag for creating a local node_modules folder
dsherret
changed the title
…l node_modules folder (#15971)
This flag is for greater compatibility with packages that depend on a local node_modules folder existing.
node_modulesfolder pnpm style -- Note: Missing peer dependency support for the first pass.Note: We cannot symlink to the global cache because that will cause resolutions to resolve to the global cache. For now, it copies, but we could hardlink if on the same file system in the future.
--local-npmname. Also, Bartek recommended this maybe be an env var. Edit: It's now--node-modules-dirCloses #15822