Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/cache): acquire reader lock before async op #16126

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

marcosc90
Copy link
Contributor

@marcosc90 marcosc90 commented Oct 1, 2022

The following snippet should throw instead of consuming the body

  const cacheName = "cache-v1";
  const cache = await caches.open(cacheName);

  const response = new Response('consumed');

  const promise = cache.put(
    new Request("https://example.com/"),
    response,
  );
  console.log(await response.text()); // consumed

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucacasonato lucacasonato merged commit a55b194 into denoland:main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants