-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): rewrite event loop #16377
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/01_core.js
Outdated
} | ||
let p = newPromise(); | ||
// Save the id on the promise so it can later be ref'ed or unref'ed | ||
p[promiseIdSymbol] = promiseId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The promise ID symbol has to be set on the promise returned by opAsync
, not on the intermediate promise, since otherwise the ID is not available to extensions that need to use {un,}refOp
.
littledivy
changed the title
perf(core): remove promise ring
perf(core): rewrite event loop
Oct 24, 2022
This was referenced Oct 25, 2022
littledivy
added a commit
that referenced
this pull request
Oct 26, 2022
Most of the changes have landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the JS promise ID -> promise mapping used to represent promises in Rust. Also gets rid of batching results to opresolve by calling the resolver function handler directly from Rust.
A promise is created in JS and the resolver function is passed to the op. The op grabs a global reference of the resolver and keeps it around for the duration of the pending future. In
JsRuntime::resolve_async_ops
, we call the resolver directly with the result.Benchmarks
`crypto.subtle.digest`
this patch:
main:
`writeFile`
Cache API
Batching 10 byte `writeFile`s (100_000 promises)