feat(bench): print iter/s in the report #19994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Aug 1, 2023
| } | ||
|
|
||
| #[test] | ||
| fn test_into_decimal_and_fractional_parts() { |
There was a problem hiding this comment.
Not really a fan of tests being so inline like this because it's noisy when scrolling between functions.
There was a problem hiding this comment.
This module hasn't really been visited since it's was added, but I'll make a note of that and do a drive-by cleanup once I touch something around testing/benchmarking in the future.
dsherret
reviewed
Aug 2, 2023
| let fractional_part = { | ||
| let decs = ((num - num.floor()) * 10.0).round(); | ||
| if decs == 10.0 { | ||
| 0 |
There was a problem hiding this comment.
I just realized I forgot to mention this. Here's a failing test case:
assert_eq!(into_decimal_and_fractional_parts(10.99), (11, 0)); // currently does 10.0
bartlomieju
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @piscisaureus