fix: canary for arm64 macos #22187
Merged
fix: canary for arm64 macos #22187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jan 30, 2024
| "github.repository == 'denoland/deno' &&", | ||
| "github.ref == 'refs/heads/main'", | ||
| "echo ${{ github.sha }} > canary-latest.txt", | ||
| 'gsutil -h "Cache-Control: no-cache" cp canary-latest.txt gs://dl.deno.land/canary-$(rustc -vV | sed -n "s|host: ||p")-latest.txt', |
There was a problem hiding this comment.
Does this mean the canary build gets uploaded even before cargo test gets run on the PR? If so, that is awesome.
dsherret
added a commit
that referenced
this pull request
Jan 30, 2024
Understandably accidentally caused by #22187
littledivy
pushed a commit
that referenced
this pull request
Feb 1, 2024
This doesn't actually trigger the arm64 build job nightly yet. I'll do that in a follow up.
littledivy
pushed a commit
that referenced
this pull request
Feb 1, 2024
Understandably accidentally caused by #22187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually trigger the arm64 build job nightly yet. I'll do that in a follow up.