perf(lsp): only store parsed sources for open documents #23454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
reviewed
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is changing the way parsed sources are analyzed for tests. Before we stored ASTs for all
file:documents so they could be used to do this in the test server. But it's better if we do that immediately after the source is parsed so we don't need to store the AST.Walking ASTs to collect tests in the document change handler would block the language server and cause a perf regression. Instead we dispatch a task there to collect them in a blocking thread, store the result in
Document::maybe_test_module_futand let that be accessed asynchronously.