Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): handle variable declarations with a declare keyword #23616

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(publish): handle variable declarations with a declare keyword #23616

merged 1 commit into from
Apr 30, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret enabled auto-merge (squash) April 30, 2024 18:47
crowlKats
crowlKats reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@dsherret dsherret merged commit 641356b into denoland:main Apr 30, 2024
17 checks passed
@dsherret dsherret deleted the fix_publish_decl_declare branch April 30, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno publish: Unexpected error for using declare const unique symbol in property of a type
2 participants
@dsherret @crowlKats