chore(ext/web): use Error.captureStackTrace in DOMException constructor
#23986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f-0b
force-pushed
the
dom-exception-native-stack
branch
from
1cf3e8b
to
b79f4e5
Compare
0f-0b
force-pushed
the
dom-exception-native-stack
branch
from
b79f4e5
to
e346d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
DOMException'sstackproperty behave the same as native errors' –stackis now an own accessor property on every instance, and the getter callsError.prepareStackTrace.denoland/deno_core#754 depends on this.