Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): don't wait for end() call to send http client request #24390

Merged
merged 7 commits into from
Jul 3, 2024
Merged

fix(ext/node): don't wait for end() call to send http client request #24390

merged 7 commits into from
Jul 3, 2024

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented Jul 2, 2024 •
edited
Loading

Closes #24232
Closes #24215

@satyarohith satyarohith added the ci-draft Run the CI on draft PRs. label Jul 2, 2024
@satyarohith satyarohith removed the ci-draft Run the CI on draft PRs. label Jul 3, 2024
@satyarohith satyarohith marked this pull request as ready for review July 3, 2024 02:21
littledivy
littledivy approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bartlomieju
bartlomieju approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, nice fix!

@satyarohith satyarohith merged commit 496ea59 into denoland:main Jul 3, 2024
17 checks passed
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@satyarohith @zebreus
fix(ext/node): don't wait for end() call to send http client request (d…
2238c75 
…enoland#24390)

Closes denoland#24232
Closes denoland#24215
@satyarohith satyarohith deleted the fix_http_client_request_stream_issue branch September 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@satyarohith @bartlomieju @littledivy