Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/http): support all .writeHead() signatures #24469

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix(node/http): support all .writeHead() signatures #24469

merged 3 commits into from
Jul 9, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Implement the missing .writeHead() signatures from Node's ServerResponse class that we didn't support.

Fixes #24468

littledivy
littledivy approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 07613a6 into main Jul 9, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the node-write-head branch July 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Node .writeHead incomplete signautre
2 participants
@marvinhagemeister @littledivy