-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(cache): single cache file for remote modules #24983
Merged
dsherret
merged 8 commits into
denoland:main
from
dsherret:perf_single_remote_cache_file2
Aug 26, 2024
Merged
perf(cache): single cache file for remote modules #24983
dsherret
merged 8 commits into
denoland:main
from
dsherret:perf_single_remote_cache_file2
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 11, 2024
.assert_matches_text( | ||
"[WILDCARD]Cache body not found. Trying again without etag.[WILDCARD]", | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted this test because it's not possible for the two files to get out of sync because there's only one file now.
bartlomieju
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is indeed much simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the global cache to store the cache file for remote modules in one file instead of two.
This has the downside of making the global cache more complicated, but I think it's worth it.(Edit: not that complicated anymore) Proposed format of the file is outlined in perf: single cache file deno_cache_dir#54On an m2 macbook loading 10k remote modules:
Closes #17707