Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: fast path for cached dyn imports #25636

Merged
merged 15 commits into from
Sep 17, 2024
Merged

perf: fast path for cached dyn imports #25636

merged 15 commits into from
Sep 17, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy changed the title upgrade deno_core choreLupgrade deno_core Sep 14, 2024
@littledivy littledivy changed the title choreLupgrade deno_core chore: upgrade deno_core Sep 14, 2024
@littledivy littledivy changed the title chore: upgrade deno_core chore: upgrade deno_core [wip] Sep 14, 2024
@littledivy littledivy marked this pull request as draft September 14, 2024 13:08
@littledivy littledivy changed the title chore: upgrade deno_core [wip] chore: upgrade deno_core Sep 14, 2024
@littledivy littledivy added the ci-draft Run the CI on draft PRs. label Sep 14, 2024
@littledivy littledivy mentioned this pull request Sep 14, 2024
Merged
@littledivy littledivy changed the title chore: upgrade deno_core perf: upgrade deno_core Sep 14, 2024
@bartlomieju
Copy link
Member

The WPT failures seem to fix broken tests from #25241. Just update the expectation.json file.

@littledivy
Copy link
Member Author

littledivy commented Sep 17, 2024 •
edited
Loading

Edit: CI passing now

@littledivy littledivy marked this pull request as ready for review September 17, 2024 07:10
@littledivy littledivy removed the ci-draft Run the CI on draft PRs. label Sep 17, 2024
@littledivy littledivy changed the title perf: upgrade deno_core perf: fast path for cached dyn imports Sep 17, 2024
@bartlomieju
Copy link
Member

@littledivy there are still 2 WPT that are passing even though they are marked as failing.

@littledivy littledivy merged commit b4faf60 into denoland:main Sep 17, 2024
17 checks passed
@littledivy littledivy deleted the update_deno-core_fast_dyn branch September 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @bartlomieju @marvinhagemeister