Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump prettier revision #2928

Merged
merged 1 commit into from
Sep 12, 2019
Merged

chore: bump prettier revision #2928

merged 1 commit into from
Sep 12, 2019

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 12, 2019

This PR bumps revision of prettier after landing denoland/std#592. It means that now type definitions will be parsed instead of big parser files.

Fixes #2490 🎉

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit a8f4421 into denoland:master Sep 12, 2019
@bartlomieju bartlomieju deleted the patch-4 branch September 12, 2019 10:35
@ry
Copy link
Member

ry commented Sep 12, 2019

This patch was a major improvement in speed for TestFmt. It went from 6 minutes (!!!) to 1.6 minutes.

I think we can still do better if we can solve #2626

Before:

> cargo build && ./tools/test.py -p fmt
   Compiling deno_cli v0.17.0 (/Users/rld/src/deno/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 18.84s
fmt (fmt_test.TestFmt) ... ok

----------------------------------------------------------------------
Ran 1 test in 362.475s

OK

After:

> cargo build && ./tools/test.py -p fmt
   Compiling deno_cli v0.17.0 (/Users/rld/src/deno/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 34.59s
fmt (fmt_test.TestFmt) ... ok

----------------------------------------------------------------------
Ran 1 test in 95.428s

OK

@bartlomieju
Copy link
Member Author

I think we can still do better if we can solve #2626

@ry partially, the best we can do is download all imports from single file at once (which should still gives us a nice speed gain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno fmt is slow
2 participants