Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split worker and worker host logic #3722

Merged
merged 8 commits into from
Jan 21, 2020
Merged

refactor: split worker and worker host logic #3722

merged 8 commits into from
Jan 21, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jan 20, 2020 •
edited
Loading

This PR:

  • splits ops/worker.rs into:
    • ops/worker_host.rs
    • ops/web_worker.rs
  • refactors js/workers.ts and factors out worker_main.ts - entry point for new Worker() isolate
  • breaking removes support for blob: URL in Worker
  • breaking removes Deno namespace support in worker - so no more noDenoNamespace option in Worker constructor
  • introduces WebWorker struct which currently is stripped down version of cli::Worker

Next PRs incoming

@bartlomieju bartlomieju changed the title [WIP] workers: spec refactor: split worker and worker host logic Jan 20, 2020
@bartlomieju bartlomieju requested a review from ry January 20, 2020 22:01
ry
ry approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please leave some detail in the commit message about what exactly is changing here

@bartlomieju bartlomieju merged commit 7966bf1 into denoland:master Jan 21, 2020
@bartlomieju bartlomieju deleted the workers_part2 branch January 21, 2020 08:49
@eliassjogreen eliassjogreen mentioned this pull request Jan 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry