-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno upgrade command #4328
deno upgrade command #4328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartossh Oh wow, I totally missed this PR. Thanks! I'm hesitant on the flate2 dependency, I'm going to try to poke at this code and see if I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ry I can think of how to remove the flate2 crate if you like. Will try to find some alternative solution in this week. Is it ok?
@kevinkassimo I will apply all your suggestions after will have response what next from @ry, to make all fixes in one go, as there I assume, may be much more of issues to fix. Thx Guys.
@bartossh How will you remove it? I was thinking about taking inspiration from how we do it in deno_install https://github.com/denoland/deno_install/blob/master/install.sh https://github.com/denoland/deno_install/blob/master/install.ps1 |
934b7d8
to
8cef839
Compare
@ry I can remove flate2 totaly and call from Rust system programs to unzip downloaded archive, like so:
And then replace the existing binary and |
@bartossh I've made some changes to remove the dependency on flate2. I wonder if you could replace my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs to work on windows
Sure, I will do. 👍 |
FYI. While making upgrade to unzip on Windows (I haven't yet tested it properly), I encountered an issue while renaming files place in the code This is the backtrace.
I am wondering if this is only going on, on my OS or maybe it is a wider problem. I will try to test it on fresh Ubuntu asap. |
9673d71
to
bf8b2d1
Compare
Ok I see @ry fixed it for Windows and for Arch based Linux it works with this change: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you very much @bartossh !
Link to issue
Used new library to unzip archive on windows / macos / unix systems: flate2 link
If any of information printed to the user should be changed, will gladly do. I haven't been sure what is best way to communicate actions taken while upgrade happens.
There is no progress indicator of download that happens in the background, and at this point I have decided to not implement this feature. If there is some, please point me where it is and I would gladly use it it.