Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "--ignore" flag to deno fmt #6890

Merged
merged 15 commits into from
Jul 30, 2020
Merged

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jul 27, 2020

Adds --ignore to deno fmt

Use case:
deno fmt --ignore=./node_modules/

Status:
Ready for review

Ref: #4459

@littledivy littledivy marked this pull request as ready for review July 27, 2020 10:43
cli/fmt.rs Outdated Show resolved Hide resolved
cli/flags.rs Outdated Show resolved Hide resolved
@nayeemrmn
Copy link
Collaborator

I wonder if we should go with --exclude. The ignore name is used for something slightly different for deno test -- it might be confusing when we bring this over there.

@ry ry added this to the 1.3.0 milestone Jul 27, 2020
@littledivy
Copy link
Member Author

I think "ignore" is more standard and easy to guess but i think you're right as it is used in deno test for a different purpose.

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2020

CLA assistant check
All committers have signed the CLA.

@littledivy littledivy changed the title feat: add "--ignore" flag to deno fmt feat: add "--exclude" flag to deno fmt Jul 28, 2020
@littledivy
Copy link
Member Author

Changed --ignore to --exclude and added --unstable check.

@littledivy littledivy requested a review from ry July 28, 2020 17:58
@nayeemrmn
Copy link
Collaborator

@divy-work Sorry, I think we should go back to --ignore to match // deno-fmt-ignore. For deno test we can use --ignore-files, having both --ignore and --exclude would be confusing anyway.

@littledivy
Copy link
Member Author

@nayeemrmn No worries. Switched back to --ignore.

@littledivy littledivy changed the title feat: add "--exclude" flag to deno fmt feat: add "--ignore" flag to deno fmt Jul 30, 2020
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @divy-work ! (Let's remove the --unstable flag before the next major release on August 13)

@ry ry merged commit 0da4779 into denoland:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants