Implement WebSocket API #7051
Implement WebSocket API #7051
Conversation
|
Currently all tests related to connecting will fail because there are leaking async ops |
|
|
lucacasonato
added
cli
| interface CloseEvent extends Event { | ||
| /** | ||
| * Returns the WebSocket connection close code provided by the server. | ||
| */ |
There was a problem hiding this comment.
nit: These could probably be made into single line doc comments
nevermind - I think these were copied directly from dom.d.ts
| this.origin = eventInitDict?.origin ?? ""; | ||
| this.lastEventId = eventInitDict?.lastEventId ?? ""; | ||
| } | ||
| } |
There was a problem hiding this comment.
Does it make sense to move the MessageEvent in a separate PR?
There was a problem hiding this comment.
i could if you want, but i dont see all that much point to it
| promise.resolve(); | ||
| }; | ||
| await promise; | ||
| }); |
There was a problem hiding this comment.
Very nice - thanks @lucacasonato for ridding us of openssl
This reverts commit ed2c19f.
|
Is this patch ready to land? |
# Conflicts: # cli/Cargo.toml # cli/build.rs
|
@ry yes |
Closes #3539.
Currently most tests dont work. Not sure how to run the websocket server simulatenously. some borrowmuterrors in some places and possible case of missing RID in eventloop when closing.