Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JSON ops to core #7336

Merged
merged 53 commits into from
Sep 6, 2020
Merged

Move JSON ops to core #7336

merged 53 commits into from
Sep 6, 2020

Conversation

piscisaureus
Copy link
Member

No description provided.

@piscisaureus piscisaureus changed the title Core json WIP: core json ops Sep 3, 2020
@piscisaureus piscisaureus changed the title WIP: core json ops Move JSON ops to core Sep 5, 2020
@piscisaureus piscisaureus requested review from ry and bartlomieju and removed request for ry September 5, 2020 21:57
cli/main.rs Show resolved Hide resolved
@@ -446,19 +446,21 @@ impl fmt::Debug for ErrWithV8Handle {
}
}

#[cfg(tests)]
#[cfg(test)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work

@piscisaureus piscisaureus merged commit c821e8f into denoland:master Sep 6, 2020
@piscisaureus piscisaureus deleted the core_json branch September 6, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants