feat(console): Support CSS styling with "%c" #7357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
reviewed
Sep 9, 2020
lucacasonato
requested changes
Sep 9, 2020
There was a problem hiding this comment.
If we are going to embed a css parser we should have some more tests. Currently it seems only color is tested (but not really because the test is ansi stripped).
Also I think we should expose parseCss for testing and add some unit testing for it. There are a lot of untested branches in parseCss otherwise.
Anyway, this will be a great feature to have :-)
nayeemrmn
force-pushed
the
console-style-format-specifier
branch
from
0e80343
to
a9fd5b1
Compare
|
Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2778.