Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsc): config resolution using relative paths #7392

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

bartlomieju
Copy link
Member

Fixes #7384

@bartlomieju bartlomieju changed the title fix(tsc): config resolution using absolute paths fix(tsc): config resolution using relative paths Sep 8, 2020
@bartlomieju
Copy link
Member Author

CC @kitsonk

@ry
Copy link
Member

ry commented Sep 8, 2020

Can we get a test?

@bartlomieju
Copy link
Member Author

Can we get a test?

I'm writing right now

@bartlomieju bartlomieju requested a review from ry September 8, 2020 13:24
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assert(actual);
assertEquals(Object.keys(actual), ["lib/foo.js.map", "lib/foo.js"]);
},
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bartlomieju bartlomieju merged commit c14436a into denoland:master Sep 9, 2020
@bartlomieju bartlomieju deleted the fix_ts_compiler_config branch September 9, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with Deno.compile filepaths in 1.3.3
2 participants