Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove std/ws connect method #7403

Merged
merged 3 commits into from
Sep 9, 2020
Merged

chore: remove std/ws connect method #7403

merged 3 commits into from
Sep 9, 2020

Conversation

lucacasonato
Copy link
Member

The web standard WebSocket API should be used instead.

bartlomieju
bartlomieju approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit a3bcdb2 into denoland:master Sep 9, 2020
@lucacasonato lucacasonato deleted the remove_ws_client branch September 9, 2020 19:33
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@lucacasonato
chore(std): remove std/ws connect method (denoland/deno#7403)
80d20bd
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@lucacasonato
chore: remove ws connect method (denoland/deno#7403)
689103b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@lucacasonato @caspervonb
chore: remove ws connect method (denoland/deno#7403)
dea23e5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@lucacasonato @caspervonb
chore: remove ws connect method (denoland/deno#7403)
f0c432f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@lucacasonato @caspervonb
chore: remove ws connect method (denoland/deno#7403)
917e937
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@lucacasonato @caspervonb
chore: remove ws connect method (denoland/deno#7403)
07f6297
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@lucacasonato @caspervonb
chore: remove ws connect method (denoland/deno#7403)
f658cc8
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@lucacasonato @denobot
chore: remove ws connect method (denoland/deno#7403)
9d0b80f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@lucacasonato @denobot
chore: remove ws connect method (denoland/deno#7403)
aca1230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @bartlomieju