[WIP] refactor(unstable): change return types in runtime compiler APIs #7496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
bartlomieju
commented
Sep 15, 2020
| @@ -524,7 +530,10 @@ declare namespace Deno { | |||
| rootName: string, | |||
| sources?: Record<string, string>, | |||
| options?: CompilerOptions, | |||
There was a problem hiding this comment.
Removing Deno.transpileOnly() in favor of noCheck option means we need to change options?: CompilerOptions into:
options?: {
noCheck?: boolean,
compilerOptions?: CompilerOptions
}
There was a problem hiding this comment.
I suspect there are other non-tsconfig related options that we will want to make in here as well, like import map, so yeah, let's change it.
| ): Promise<[Diagnostic[] | undefined, Record<string, string>]>; | ||
| ): Promise<{ | ||
| diagnostics: Diagnostic[] | undefined, | ||
| emitMap: Record<string, string> |
There was a problem hiding this comment.
rename to emittedFiles
| @@ -524,7 +530,10 @@ declare namespace Deno { | |||
| rootName: string, | |||
| sources?: Record<string, string>, | |||
| options?: CompilerOptions, | |||
| ): Promise<[Diagnostic[] | undefined, Record<string, string>]>; | |||
| ): Promise<{ | |||
| diagnostics: Diagnostic[] | undefined, | |||
There was a problem hiding this comment.
add ignoredCompilerOptions field
|
Waiting to close #7225 before finishing this PR |
|
Stale, I'll open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4752
CC @kitsonk