Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno bundle supports export * exports #7607

Closed

Conversation

JordanMajd
Copy link

Fixes #7518

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020

CLA assistant check
All committers have signed the CLA.

@kitsonk
Copy link
Contributor

kitsonk commented Sep 21, 2020

Great contribution. It would be really good to get a test case for this. There are a few bundle* integration tests in cli/integration_tests.rs that provide an example of how to build such a test.

@kitsonk kitsonk mentioned this pull request Sep 23, 2020
18 tasks
@JordanMajd
Copy link
Author

JordanMajd commented Oct 1, 2020

FYI, I haven't forgotten about this and have set aside time tomorrow night to add the tests.

@bartlomieju
Copy link
Member

@kitsonk do you want to pursue landing this PR or is it something that will be addressed in compiler refactor?

@kitsonk
Copy link
Contributor

kitsonk commented Oct 23, 2020

Thanks for the effort, but the refactor of how we are compiling code (#7225) is making this redundant. This is now fixed in master with #8071 and will soon be resolved for Deno.bundle(). So going to close without merge.

@kitsonk kitsonk closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.bundle causes Assertion error in the TS compiler
4 participants