Py3 compat #7779
Merged
Py3 compat #7779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, is this all we need for #2893 now? |
That's as far as I can tell. This works on OSX and Linux. |
|
Should this be python 3 for at least some of the build matrix? |
That's a point I forgot to consider. Maybe this issue should be addressed in the context of sunsetting python 2. The intention with this PR was just to make the tests play nice with python 3. I have a weird feeling about changing up the python versions in just some places. |
|
This may regress without using python3 in at least one test in the matrix (e.g. linux). Note: Building with python3 works provided you don't build V8. 😎 |
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Oct 2, 2020
Soremwar
pushed a commit
to Soremwar/deno
that referenced
this pull request
Oct 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes build scripts compatible with python 3.