Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(std/fs/node): adding some functions #7921

Merged
merged 73 commits into from
Oct 14, 2020
Merged

feat(std/fs/node): adding some functions #7921

merged 73 commits into from
Oct 14, 2020

Conversation

AliBasicCoder
Copy link
Contributor

fixing #7666 maybe?

AliBasicCoder and others added 30 commits September 26, 2020 21:47
@AliBasicCoder
adding some functions to std/node/fs
752481b
@AliBasicCoder
adding fs.watch
9ab7295
@AliBasicCoder
handling "bigint" options in fs.stat and fs.lstat
93615bb
@AliBasicCoder
adding "Ns" properties in BigIntStat
d939faa
@AliBasicCoder
adding fs.open
13fa5e8
@AliBasicCoder
..
8d9cf2a
@AliBasicCoder
fixing litting issues
433bfdd
@AliBasicCoder
adding testing
593e07e
@AliBasicCoder
fix formating
47103d8
@AliBasicCoder
fixing testing
1be4331
@AliBasicCoder
formating
954dd73
@AliBasicCoder
..
52c5db8
@AliBasicCoder
..
1df746c
@AliBasicCoder
fixing "@ts-ignore" issue
bfd5dfc
@AliBasicCoder
..
035c839
@AliBasicCoder
adding test for open and watch
397ad61
@AliBasicCoder
fixing open
397e523
@AliBasicCoder
fix watch testing
04e3805
@AliBasicCoder
litting and formating
26c6084
@AliBasicCoder
Merge branch 'master' into add_fs_functions
de0d8af
@AliBasicCoder
Update fs.ts
080293b
@AliBasicCoder
..
b2f0f59
@AliBasicCoder
using options in readdir and readdirSync
474a201
@AliBasicCoder
add "as" and "as+" flag to open and openSync
e205bf8
@AliBasicCoder
adding testing for flags "as" & "as+"
cfbd351
@AliBasicCoder
fixing issue
8319bde
@AliBasicCoder
fix linting and format
446f60b
@AliBasicCoder
fix issuse
25fd061
@AliBasicCoder
fix format
d3d67e4
@AliBasicCoder
using Dirent and getOpenOptions
366025d
@AliBasicCoder AliBasicCoder mentioned this pull request Oct 10, 2020
Merged
@AliBasicCoder AliBasicCoder marked this pull request as ready for review October 11, 2020 09:13
@AliBasicCoder
Copy link
Contributor Author

NOTE: tests for rmdir and rmdirSync for non-empty folders are ignored in windows

@AliBasicCoder
Copy link
Contributor Author

@ry

@AliBasicCoder
Copy link
Contributor Author

@denobot

ry
ry approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for resubmitting. We’ve fixed the underlying bug so this should be fine.

@ry ry merged commit 5bed06f into denoland:master Oct 14, 2020
@AliBasicCoder AliBasicCoder deleted the add_fs_functions branch October 15, 2020 14:06
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@AliBasicCoder
feat(std/fs/node): adding some functions (denoland/deno#7921)
72a9bcf
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@AliBasicCoder
feat(fs/node): adding some functions (denoland/deno#7921)
72602d9
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@AliBasicCoder @caspervonb
feat(fs/node): adding some functions (denoland/deno#7921)
2f63f48
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@AliBasicCoder @caspervonb
feat(fs/node): adding some functions (denoland/deno#7921)
ae7b78f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@AliBasicCoder @caspervonb
feat(fs/node): adding some functions (denoland/deno#7921)
ebc1a2d
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@AliBasicCoder @caspervonb
feat(fs/node): adding some functions (denoland/deno#7921)
60634ee
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@AliBasicCoder @caspervonb
feat(fs/node): adding some functions (denoland/deno#7921)
7a80a59
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@AliBasicCoder @denobot
feat(fs/node): adding some functions (denoland/deno#7921)
bd7e46e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@AliBasicCoder @denobot
feat(fs/node): adding some functions (denoland/deno#7921)
44c22ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliBasicCoder @ry