fix(cli): ModuleGraph2 properly handles redirects #7981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bit more detail about this... ModuleGraph2 no has a hash of all the redirects and when a module is attempted to be resolved, it will keep recursively looking up any redirects until the point where it no longer gets redirected, and then attempts to look the module up in the graph. Currently the file_fetcher simply returns the "final" Url for a fetched file, so when the module is added to the graph, it only has one potential redirect. If in the future we surface up the entire change, that will "just work" with the graph, because of the recursive way it resolves modules. I've tried this on my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where both
--no-checkanddeno infodo not currently handle redirects.