Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(std/wasi): disallow path_open outside of pre-opened dirfd #8078

Merged
merged 16 commits into from
Oct 24, 2020
Merged

fix(std/wasi): disallow path_open outside of pre-opened dirfd #8078

merged 16 commits into from
Oct 24, 2020

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Oct 22, 2020 •
edited
Loading

Disallow path_open to open paths outside of the dirfd that is being accessed.

@caspervonb caspervonb changed the title [WIP] fix(std/wasi): disallow path_open outside of pre-opened dirfd fix(std/wasi): disallow path_open outside of pre-opened dirfd Oct 22, 2020
@caspervonb caspervonb marked this pull request as ready for review October 22, 2020 23:17
@caspervonb caspervonb marked this pull request as draft October 22, 2020 23:31
@caspervonb caspervonb marked this pull request as ready for review October 22, 2020 23:56
@caspervonb
Copy link
Contributor Author

Think I might have stumbled upon a bug with symlinks and/or std/fs/copy.
Unix works fine, but on Windows symlink_to_parent_directory (a relative symlink with ..) doesn't appear to be a symlink at all.

Don't have a windows machine to work on this with so this is very difficult to debug.

@lucacasonato
Copy link
Member

Unix works fine, but on Windows symlink_to_parent_directory (a relative symlink with ..) doesn't appear to be a symlink at all.

cc @piscisaureus

@caspervonb
Copy link
Contributor Author

caspervonb commented Oct 23, 2020 •
edited
Loading

I'm appending this new test to the growing list of ignored windows tests for the time being until I get around to provisioning a Windows based server to fix them all.

Windows behaviour isn't any worse than it was before this commit, the new tests just make it more obvious that some symlink cases are probably broken on Windows, most likely the test runner itself is at fault.

@caspervonb caspervonb mentioned this pull request Oct 24, 2020
Merged
bartlomieju
bartlomieju approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 2a83b22 into denoland:master Oct 24, 2020
@caspervonb caspervonb mentioned this pull request Oct 28, 2020
Merged
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@caspervonb
fix(std/wasi): disallow path_open outside of pre-opened dirfd (denola…
6c62f9a 
…nd/deno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
ffd75b3 
…eno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
e0eae52 
…eno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
df94bd9 
…eno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
05e6783 
…eno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
66f87be 
…eno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
efab242 
…eno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb @denobot
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
dbffb47 
…eno#8078)
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@caspervonb @denobot
fix(wasi): disallow path_open outside of pre-opened dirfd (denoland/d…
cb49d52 
…eno#8078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caspervonb @lucacasonato @bartlomieju