Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(std/wasi): return exit code from start #9022

Merged

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Jan 6, 2021

This returns the exit code directly from the start entry point instead of throwing it and making the user handle that specific kind of error which is a bit too convoluted.

As a result the exit status is an implementation detail and has been made internal.

This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit f4b03a8 into denoland:master Jan 6, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
This returns the exit code directly from the start entry point instead
of throwing it and letting the user handle it.

As a result the exit status is an implementation detail and has been
made internal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants