-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(std/wasi): return exit code from start #9022
Merged
ry
merged 1 commit into
denoland:master
from
caspervonb:breaking-std-wasi-return-exit-code-from-start
Jan 6, 2021
Merged
BREAKING(std/wasi): return exit code from start #9022
ry
merged 1 commit into
denoland:master
from
caspervonb:breaking-std-wasi-return-exit-code-from-start
Jan 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
ry
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
This returns the exit code directly from the start entry point instead of throwing it and letting the user handle it. As a result the exit status is an implementation detail and has been made internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns the exit code directly from the start entry point instead of throwing it and making the user handle that specific kind of error which is a bit too convoluted.
As a result the exit status is an implementation detail and has been made internal.