Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/flags): Don't panic on invalid location scheme #9202

Merged
merged 3 commits into from
Jan 24, 2021
Merged

fix(cli/flags): Don't panic on invalid location scheme #9202

merged 3 commits into from
Jan 24, 2021

Conversation

nayeemrmn
Copy link
Collaborator

deno run --location file:/// mod.ts panics.

@nayeemrmn nayeemrmn mentioned this pull request Jan 22, 2021
Closed
kt3k
kt3k approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucacasonato
lucacasonato approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lucacasonato lucacasonato merged commit 452df2f into denoland:master Jan 24, 2021
@nayeemrmn nayeemrmn deleted the location-invalid-scheme branch January 24, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nayeemrmn @kt3k @lucacasonato @crypt096