Improve tools/unit_tests.py #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
commented
Oct 11, 2018
| "--allow-write", | ||
| "--allow-net", | ||
| "--allow-env", | ||
| ]) |
There was a problem hiding this comment.
permW1N1E1 was removed because there are no unit tests which use all three.
ry
force-pushed
the
unit_test_output
branch
2 times, most recently
from
5beb7b6
to
51b14ff
Compare
hayd
reviewed
Oct 11, 2018
tools/unit_tests.py
Outdated
| raise TypeError("Bad js/unit_test.ts output") | ||
| if expected != actual: | ||
| print "expected", expected, "actual", actual | ||
| raise TypeError("expected tests did not equal actual") |
There was a problem hiding this comment.
nit but this probably ought to be an AssertionError (not a TypeError).
Checks the output more carefully. The first line of output from js/unit_tests.ts should be something like "running 96 tests" And the last line should be something like "test result: ok. 96 passed; 0 failed; 0 ignored; 0 measured; 36 filtered out" This parses those strings and make sure they align. This will catch silent death bugs.
Closed
|
@piscisaureus PTAL |
| run_unit_test(deno_exe, "permW1N0E0", ["--allow-write"]) | ||
| run_unit_test(deno_exe, "permW0N1E0", ["--allow-net"]) | ||
| run_unit_test(deno_exe, "permW0N0E1", ["--allow-env"]) | ||
| # TODO We might accidentally miss some. We should be smarter about which we |
There was a problem hiding this comment.
Yeah i worry about that too.
We could also do some typescript trick with the DenoPermissions type in the test runner so it only allows the 4 permutations listed here. Then it'd be obvious when a new test uses a flag combination that doesn't get run.
type Exact<A extends object> = A & { __kind: keyof A };
type DenoPermissions =
Exact<{} | { write: true } | { net: true } | { env: true }>;
piscisaureus
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the output more carefully. The first line of output from
js/unit_tests.ts should be something like "running 96 tests"
And the last line should be something like
"test result: ok. 96 passed; 0 failed; 0 ignored; 0 measured; 36
filtered out"
This parses those strings and make sure they align.
This will catch silent death bugs.