-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement compiler options #29
Comments
Any update on this? Looking to support specifying a Can't even use I guess I'll need to use esbuild or something in the meantime - feels like we've lost so much since deno v1.21.3. (update) was able to use the esbuild Deno x module to bundle with a custom |
Hmm, I'm also stuck trying to find a replacement for old compilerOptions: {
declaration: true,
emitDeclarationOnly: true,
removeComments: false,
} It seems there is no upgrade path for me.
Any ideas? |
I also don't understand the reason for including export async function bundle(
root: string | URL,
options: BundleOptions = {},
): Promise<BundleEmit> {
const {
imports,
load,
cacheSetting,
cacheRoot,
allowRemote,
compilerOptions
} = options;
let bundleLoad = load;
if (!bundleLoad) {
const cache = createCache({ root: cacheRoot, cacheSetting, allowRemote });
bundleLoad = cache.load;
}
root = root instanceof URL ? root : toFileUrl(resolve(root));
const { bundle: jsBundle } = await instantiate();
console.log('got compiler options', compilerOptions)
return jsBundle(
root.toString(),
bundleLoad,
JSON.stringify(imports),
undefined,
compilerOptions,
);
} |
Since the initial release, the bundle type, the compiler options and the imports were not properly forwarded from JS to Rust. We now forward them, and added some tests to verify this behaviour. Closes denoland#83, denoland#69, denoland#29.
Since the initial release, the bundle type, the compiler options and the imports were not properly forwarded from JS to Rust. We now forward them, and added some tests to verify this behaviour. Closes denoland#83, denoland#69, denoland#29.
Since the initial release, the bundle type, the compiler options and the imports were not properly forwarded from JS to Rust. We now forward them, and added some tests to verify this behaviour. Closes denoland#83, denoland#69, denoland#29.
Since the initial release, the bundle type, the compiler options and the imports were not properly forwarded from JS to Rust. We now forward them, and added some tests to verify this behaviour. Closes denoland#83, denoland#69, denoland#29.
Currently the compiler options are ignored (or not available). They need to be passed to Rust and affect the emit just like with CLI.
The text was updated successfully, but these errors were encountered: