Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle always has inline source maps even if inlineSources and inlineSourceMap are false #83

Closed
JustinGrote opened this issue Dec 11, 2022 · 1 comment · Fixed by #98

Comments

@JustinGrote
Copy link

import { bundle } from "https://deno.land/x/emit@0.12.0/mod.ts";
const result = await bundle("./src/worker.ts", {
	compilerOptions: {
		inlineSourceMap: false,
		inlineSources: false,
		sourceMap: true
	}
})

console.log(result.code)
console.log("SOURCE MAP")
console.log(result.map)

Always generates a base64 sourcemap inline URL and the map property is undefined. I've tried all sorts of combinations of these settings with the same result.

@kamilogorek
Copy link
Contributor

Should be fixed with #63

yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 4, 2023
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 9, 2023
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 25, 2023
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 26, 2023
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
dsherret pushed a commit that referenced this issue Apr 26, 2023
Forward arguments from JS to Rust

Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes #83, #69, #29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants