Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maybe Upgrade Needed] - Possible Regression with Deno 1.31.2 #1073

Closed
bjesuiter opened this issue Mar 11, 2023 · 3 comments
Closed

[Maybe Upgrade Needed] - Possible Regression with Deno 1.31.2 #1073

bjesuiter opened this issue Mar 11, 2023 · 3 comments

Comments

@bjesuiter
Copy link
Contributor

Hi Fresh Team,

I already reported a possible regression with fresh and deno 1.31.2 to the deno issue tracker, see denoland/deno#18137.
However, I thought, it might be best to also bring it up here since the problem is extremely annoying.

Side Note: I work in this repo: https://github.com/codemonument/deno_audio_logbook

Short Problem Description

When I start the dev server by using deno task start,
it works at first , but when I change anything in any watched file,
it seems to recompile successfully, but it can't restart the server correctly,
stating that "Adress is already in use".

deno task start
Task start doppler run -- deno run -A --cached-only --watch=static/,routes/ dev.ts
Watcher Process started.
The manifest has been generated for 5 routes and 4 islands.
loadSecrets: 462ms
initDb: 813ms
Watcher File change detected! Restarting!
loadSecrets: 828ms
initDb: 1331ms
PostCSS Transformed and Cached: /Users/bjesuiter/Develop/codemonument/deno_audio_logbook/css/global.css { fileHash: "ptYaR1kyC6IFD87cIeOC6y9DmGXlAE8T6/ALXQzupNk=" }
error: Uncaught AddrInUse: Address already in use (os error 48)
    const listener = Deno.listen({
                          ^
    at Object.listen (ext:deno_net/01_net.js:356:39)
    at Server.listenAndServe (https://deno.land/std@0.150.0/http/server.ts:181:27)
    at serve (https://deno.land/std@0.150.0/http/server.ts:589:20)
    at start (https://deno.land/x/fresh@1.1.4/src/server/mod.ts:70:11)
    at async file:///Users/bjesuiter/Develop/codemonument/deno_audio_logbook/main.ts:14:1
Watcher Process finished. Restarting on file change...

This seems like a timing problem between stopping the old server and starting the new one, or an internal behavior change in the deno http server.

@lino-levan
Copy link
Contributor

This is fixed in canary, so either upgrade to that or downgrade to 1.30.0. I believe they are adding some tests to prevent this from happening for a third time.

@bjesuiter
Copy link
Contributor Author

Yes, I've downgraded to 1.31.1 thank you for the heads up!

@bjesuiter
Copy link
Contributor Author

Have closed the issue, bc. i think it will be fixed soon and there is a hotfix available by doing

deno upgrade --version 1.31.1

kt3k pushed a commit to denoland/deno that referenced this issue Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants