Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 1.31.2, server doesn't shutdown gracefully #18120

Closed
Antonio476587 opened this issue Mar 10, 2023 · 3 comments · Fixed by #18157
Closed

Regression in 1.31.2, server doesn't shutdown gracefully #18120

Antonio476587 opened this issue Mar 10, 2023 · 3 comments · Fixed by #18157

Comments

@Antonio476587
Copy link
Contributor

When I run this code with the --watch flag and trigger a change, it throws an error.

import { serve } from "https://deno.land/std@0.114.0/http/server.ts";

serve((_req) => new Response("Hello, world"));

Error:

Watcher File change detected! Restarting!
✅ Granted net access to "0.0.0.0:8000".
error: Uncaught AddrInUse: Address already in use (os error 98)
    const listener = Deno.listen({
                          ^
    at Object.listen (ext:deno_net/01_net.js:356:39)
    at Server.listenAndServe (https://deno.land/std@0.114.0/http/server.ts:232:27)
    at serve (https://deno.land/std@0.114.0/http/server.ts:614:23)
    at file:///home/seo/Documents/Programming/portfolio-new/loopTester.ts:4:1
Watcher Process finished. Restarting on file change...
@GJZwiers
Copy link
Contributor

Related: #16699 (comment)

@GJZwiers
Copy link
Contributor

Did a bisect, looks like 0cce9c2 re-introduced the error.

@dsherret
Copy link
Member

Seems it should be reverted. cc @littledivy @bartlomieju

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants