fix: redefine opaque pathname detection for custom protocols #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hirochachacha
force-pushed
the
fix-opaque-pathname-detection
branch
3 times, most recently
from
823d18b to
7b5f068
Compare
…d#61) Changes opaque pathname detection logic to treat pathnames as non-opaque when: - Protocol is empty - Protocol is a special scheme (http, https, ws, wss, ftp, file) - Pathname has a leading '/' (indicating hierarchical path) This fixes issue denoland#61 (denoland/deno#29935) where custom protocols like myprotocol://example.com/:directory/:file were incorrectly escaping pattern syntax in pathnames. Fixes denoland#61
hirochachacha
force-pushed
the
fix-opaque-pathname-detection
branch
from
7b5f068 to
edbcb38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue denoland/deno#29935 by redefining how opaque pathnames are detected for custom protocols.
Changes
Modified opaque pathname detection logic to treat pathnames as non-opaque when:
Updated both
process_pathname_initand the pathname compilation logic to use consistent criteriaTest Plan
issue61that verifies:myhttp://example.com/:directory/:file→ pathname:/:directory/:file(not escaped)myfile:///test→ pathname:/test(not escaped)Background
Previously, custom protocols like
myprotocol://example.com/:directory/:filewould have their pathname pattern syntax (colons) incorrectly escaped as%2F:directory%2F:file. This was because the logic only considered whether the protocol was a "special scheme" when determining if a pathname should be treated as opaque.The new logic recognizes that any pathname starting with
/is hierarchical and should not be treated as opaque, regardless of the protocol.Fixes denoland/deno#29935
🤖 Generated with Claude Code