Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsonc): annotate return types #3327

Merged
merged 5 commits into from
Apr 24, 2023
Merged

feat(jsonc): annotate return types #3327

merged 5 commits into from
Apr 24, 2023

Conversation

jsejcksn
Copy link
Contributor

Previously, return type annotations were missing and the type JsonValue was duplicated.

@jsejcksn jsejcksn requested a review from kt3k as a code owner April 22, 2023 15:34
kt3k
kt3k approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 1ca00cb into denoland:main Apr 24, 2023
@jsejcksn jsejcksn deleted the feat/jsonc-types branch April 24, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsejcksn @kt3k