Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsonc): annotate return types #3327

Merged
merged 5 commits into from
Apr 24, 2023
Merged

feat(jsonc): annotate return types #3327

merged 5 commits into from
Apr 24, 2023

Commits on Apr 22, 2023

  1. feat(jsonc): annotate return types

    @jsejcksn
    jsejcksn committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    45de283 View commit details
    Browse the repository at this point in the history

  2. deduplicate type JsonValue 

    import (and re-export) from json/common.ts
    @jsejcksn
    jsejcksn committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    7859e99 View commit details
    Browse the repository at this point in the history

  3. use PascalCase for enum 

    Idiomatic TypeScript uses PascalCase for types and enums
    @jsejcksn
    jsejcksn committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    38121e9 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary const assertions

    @jsejcksn
    jsejcksn committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ba13163 View commit details
    Browse the repository at this point in the history

  5. use camelCase for method names

    @jsejcksn
    jsejcksn committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    b5488ca View commit details
    Browse the repository at this point in the history