Expose Special issue types endpoint throughout the BIP API service #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Test Coverage
|
brostk
reviewed
Aug 13, 2024
svc-bip-api/src/main/java/gov/va/vro/bip/model/contentions/GetSpecialIssueTypesResponse.java
Outdated
Show resolved
Hide resolved
brostk
approved these changes
Aug 13, 2024
dfitchett
reviewed
Aug 13, 2024
...api/src/main/java/gov/va/vro/mockbipclaims/model/bip/response/SpecialIssueTypesResponse.java
Show resolved
Hide resolved
svc-bip-api/src/main/java/gov/va/vro/bip/model/contentions/GetSpecialIssueTypesResponse.java
Outdated
Show resolved
Hide resolved
svc-bip-api/src/main/java/gov/va/vro/bip/model/contentions/ParameterlessBipRequest.java
Outdated
Show resolved
Hide resolved
lisac
approved these changes
Aug 13, 2024
...-bip-claims-api/src/main/java/gov/va/vro/mockbipclaims/controller/ContentionsController.java
Outdated
Show resolved
Hide resolved
svc-bip-api/src/integrationTest/java/gov/va/vro/bip/SpecialIssueTypesTest.java
Outdated
Show resolved
Hide resolved
svc-bip-api/src/main/java/gov/va/vro/bip/config/BipApiConfig.java
Outdated
Show resolved
Hide resolved
svc-bip-api/src/test/java/gov/va/vro/bip/service/BipApiServiceTest.java
Outdated
Show resolved
Hide resolved
nelsestu
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ng PR feedback with minor edits as identified in PR #3280 comments.
…s the following commits:
Laying the ground work for the special issue types endpoint. Also building out the mock data service that we'll need for local development purposes.
Get the mock bip api service up and running, with unit test coverage
Introduces SpecialIssueStateService which handles population of the state attribute. With this, requests for special issue types now allows for an array of codes while resolving the state attribute based on the functionality described in #3213. Still working through some integration test error with Spring dependency injection.
Fix special issue types service, by refactoring both BipApiService and SpecialIssueStateService to descend from a common RestApiService abstract class. This will allow for easier integration testing of the special issue types functionality.
simplifying special issue types implementation by eliminating the getSpecialIssueCodes call, and favoring a direct pass through call to the bip api.'
Rebasing with develop to refresh this aging branch. Incorporating PR feedback with minor edits as identified in PR #3280 comments.
Reapply some of the merge resolutions after the rebase
nelsestu
force-pushed
the
3213-special-issue-types
branch
from
283c7f1
to
d6bb412
Compare
Co-authored-by: Lisa Chung <lisac@users.noreply.github.com>
…ng PR feedback with minor edits as identified in PR #3280 comments.
dfitchett
force-pushed
the
3213-special-issue-types
branch
from
8074705
to
40c2301
Compare
dfitchett
force-pushed
the
3213-special-issue-types
branch
from
40c2301
to
a43daf3
Compare
dfitchett
approved these changes
Aug 16, 2024
nelsestu
commented
Aug 20, 2024
There was a problem hiding this comment.
Thanks @dfitchett , I wasn't understanding how the unrelated integration test would be failing, but removing the extra RestTemplate mock that was being created certainly makes sense in hindsight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EE team has requested that the special_issue_types endpoint be exposed via a new rabbitmq queue on the bip exchange. This PR introduces many of the necessary components towards making that endpoint available for EE consumption. Accompanying the real bip data, is a mock implementation that can be used for local development.
What was the problem?
special_issue_types were needed.
Associated tickets or Slack threads:
How does this fix it?1
Adds the special_issue_types endpoint to all the necessary components of the bip service.
How to test this PR
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩