Correspondence CSS Issues - Using Glamor instead of classnames #22173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacevesva
approved these changes
Jul 16, 2024
Rnmarshall93
added a commit
that referenced
this pull request
Jul 24, 2024
* removed all glamor css. * fixed linting.
cacevesva
added a commit
that referenced
this pull request
Jul 26, 2024
…an Appeal (#22262) * backend serializer updated, regressions fixed * pushing up correspondence timeline * Fixed import issue. * added correspondence versions of case timeline. fixed some data appearing. * changes to timeline * Fixed the extra line issue * additional changes * additional formatting fix * additional fixes, refined taskrows * task dropdown added * checkpoint for testing * lenting fixes * fff * Fixed organization having the ability to edit tasks. * Removed stray console logs * fixed assigned_to not being displayed. lint fixes. * linting fixes * css improvements * added label method to give correct tasks * fixed show instructions bug * component cleanup * refactored out unused logic * fixed CSS, added missed AC point. * removed binding pry * Correspondence CSS Issues - Using Glamor instead of classnames (#22173) * removed all glamor css. * fixed linting. * add Errno::EISDIR to clear_cache rescue block (#22114) * APPEALS-51230: Add tmp/examples.txt to Github Actions artifacts (#22124) * add examples.txt to gha workflow * rename examples and bullet files even if failure * APPEALS-42516 - CSS Updates (#22191) * APPEALS-42516 - CSS Updates * APPEALS-42516 - Additional CSS for View all link * Deleting empty rulesets for linter * Lintagain * &nsp removal --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Completed Tabs link code modifications (#22192) * Completed Tabs link code modifications * Modified the code changes as commented * verbiage change (#22217) * APPEALS-51992: Veteran Name Does Not update when file number changed (#22218) * return the updated serialized correspondence when updating * removed unused veteranInformation (#22221) * made edit to review form so that only supervisors could edit the VA DOR date (#22227) * APPEALS-51383: Resolve Bugs with Inbound Ops team Queues on Switch Views Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method. * APPEALS-51552: Test Appeal Organization tables (#22237) * filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues. * Justin/APPEALS-50741 (#22219) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * adding temporary under_constructions task urls for merge and split tasks. (#22256) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * adding temporary under_constructions task urls for merge and split tasks. * Ki/APPEALS-42518 - All users: Can view correspondence record status (#22226) * APPEALS-32518 - Added recordStatus to page pathways * APPEALS-42518 - Updated Correspondence Status pathways, controller * APPEALS-42518 - Remap status to live in correspondence model * Remove unedited file linting changes * Second filechange * APPEALS-42518 - Updated RSpecs * Linting --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Sivakesh/APPEALS-42522 - Completed Mail Tasks (#22254) * #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * Div/appeals 50296 (#22266) * Fix for pdf not loading in review package task * Added a comment line * Rubocp fix * Codeclimite fixes --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Removed the Inbound ops Team from rejected_orgs (#22284) * fixed missing comma breaking code * Completed Tabs link code modifications (#22192) * Completed Tabs link code modifications * Modified the code changes as commented * Justin/APPEALS-50741 (#22219) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * Ki/APPEALS-42518 - All users: Can view correspondence record status (#22226) * APPEALS-32518 - Added recordStatus to page pathways * APPEALS-42518 - Updated Correspondence Status pathways, controller * APPEALS-42518 - Remap status to live in correspondence model * Remove unedited file linting changes * Second filechange * APPEALS-42518 - Updated RSpecs * Linting --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Sivakesh/APPEALS-42522 - Completed Mail Tasks (#22254) * #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * removed unused code. fixed jest tests. * changed if to unless * changed styling of attribute for assigned_to * removed whitespace * Khalin/appeals 42564 v3 (#22304) * WIP * Modified few changes for this relations to work * added create logic in intake * cleaned up associations * Associations and up/down migrations working * WIP Failing tests * Fixed spec/lib/helpers/association_wrapper_spec.rb * Rubocop fixes * Updated migration file * Fixing migration error * Rubocop fix * All tests passing --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> * Vinner57/appeals 42526 Correspondence and Appeal Tasks: Can view existing appeals related to the Veteran (#22261) * Adding the veteran related changes in correspondence details * Adding the changes to correspondence serializer * Adding the changes to correspondence details for the veteran information * fix for code climate and table border * #50661 - Jest tests for existing appeals * #50661 - undo yarn lock file * #42526 - css, jest tests, lint and merge conflicts * #42526 - lint and jest fixes * addressing PR comments * fix rubocop * #42526 - removed AptUtil usages --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Sivakesh/APPEALS-42522 - Completed Mail Tasks (#22303) * #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * #52600 - 508 compliance code fix * #52600 - 508 compliance code fix --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * APPEALS-49005 - Bugfix: Reassign Correspondence Allows Reassignment to Admins (#22297) * APPEALS-49005 - Added non_admin function for more limited user list * Unneeded Prop * Update admin check --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * APPEALS-44287: Excluding disposition held and select that appeal for distribution (#22277) * first run at an SQL query removing duplicate appeals from distribution * code refactor and excluding disposition held and select that appeal for distribution * automated test for the duplicate hearing bug * fix rubocop offense SpaceInsideBlockBraces --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: samasudhirreddy <sudhirreddy.sama@va.gov> * Kev ma/appeals 51520 seeddata fix (#22307) * Removed non valid ce api documents types from uat * Added ce api valid vbms document type ids for uat --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * fixed css on margin for text * Vinner57/appeals 42526 Correspondence and Appeal Tasks: Can view existing appeals related to the Veteran (#22261) * Adding the veteran related changes in correspondence details * Adding the changes to correspondence serializer * Adding the changes to correspondence details for the veteran information * fix for code climate and table border * #50661 - Jest tests for existing appeals * #50661 - undo yarn lock file * #42526 - css, jest tests, lint and merge conflicts * #42526 - lint and jest fixes * addressing PR comments * fix rubocop * #42526 - removed AptUtil usages --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * fixed linting error. * fixed tests * lint fix * fixed linting issue --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: samasudhirreddy <sudhirreddy.sama@va.gov> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Correspondence CSS Issues - Using Glamor instead of classnames
Description
This PR removes the use of all glamor objects, and also places all Colors object references so that they use CSS instead, or in the case that components are not compatible with classnames, uses an object to hold the style. The files changed are
The ticket also mentions other components to remove glamor from, but they are not using glamor so it's assumed it was removed via changes that this ticket didn't track. AddEvidenceSubmissionView.jsx is the only component that had to use an object instead of class names.
Acceptance Criteria