-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appeals-42530: Correspondence and Appeal Tasks: Tasks not related to an Appeal #22262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed all glamor css. * fixed linting.
* add examples.txt to gha workflow * rename examples and bullet files even if failure
* APPEALS-42516 - CSS Updates * APPEALS-42516 - Additional CSS for View all link * Deleting empty rulesets for linter * Lintagain * &nsp removal --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* Completed Tabs link code modifications * Modified the code changes as commented
* Fix for pdf not loading in review package task * Added a comment line * Rubocp fix * Codeclimite fixes --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* Completed Tabs link code modifications * Modified the code changes as commented
* overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors
…22226) * APPEALS-32518 - Added recordStatus to page pathways * APPEALS-42518 - Updated Correspondence Status pathways, controller * APPEALS-42518 - Remap status to live in correspondence model * Remove unedited file linting changes * Second filechange * APPEALS-42518 - Updated RSpecs * Linting --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks
cacevesva
requested changes
Jul 25, 2024
app/models/tasks/mail_tasks_not_related_to_appeal/cavc_correspondence_correspondence_task.rb
Outdated
Show resolved
Hide resolved
* WIP * Modified few changes for this relations to work * added create logic in intake * cleaned up associations * Associations and up/down migrations working * WIP Failing tests * Fixed spec/lib/helpers/association_wrapper_spec.rb * Rubocop fixes * Updated migration file * Fixing migration error * Rubocop fix * All tests passing --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>
…ting appeals related to the Veteran (#22261) * Adding the veteran related changes in correspondence details * Adding the changes to correspondence serializer * Adding the changes to correspondence details for the veteran information * fix for code climate and table border * #50661 - Jest tests for existing appeals * #50661 - undo yarn lock file * #42526 - css, jest tests, lint and merge conflicts * #42526 - lint and jest fixes * addressing PR comments * fix rubocop * #42526 - removed AptUtil usages --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * #52600 - 508 compliance code fix * #52600 - 508 compliance code fix --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
…o Admins (#22297) * APPEALS-49005 - Added non_admin function for more limited user list * Unneeded Prop * Update admin check --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
…distribution (#22277) * first run at an SQL query removing duplicate appeals from distribution * code refactor and excluding disposition held and select that appeal for distribution * automated test for the duplicate hearing bug * fix rubocop offense SpaceInsideBlockBraces --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: samasudhirreddy <sudhirreddy.sama@va.gov>
* Removed non valid ce api documents types from uat * Added ce api valid vbms document type ids for uat --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
…ting appeals related to the Veteran (#22261) * Adding the veteran related changes in correspondence details * Adding the changes to correspondence serializer * Adding the changes to correspondence details for the veteran information * fix for code climate and table border * #50661 - Jest tests for existing appeals * #50661 - undo yarn lock file * #42526 - css, jest tests, lint and merge conflicts * #42526 - lint and jest fixes * addressing PR comments * fix rubocop * #42526 - removed AptUtil usages --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
cacevesva
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Correspondence and Appeal Tasks: Tasks not related to an Appeal
Description
As a Caseflow user, I need to view a Tasks not related to an Appeal section on the correspondence details page so I can take action if necessary.
Acceptance Criteria
Testing Plan