Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ki/APPEALS-51359 - Only render Correspondences that are in Pending or Completed status #22726

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

KiMauVA
Copy link
Contributor

@KiMauVA KiMauVA commented Sep 5, 2024

Resolves APPEALS-51359 - Only render Correspondences that are in Pending or Completed status

Description

Added additional logic to the Correspondence Details controller to only populate the details page for correspondence statuses that are either Complete or Pending.

If the correspondence does not meet those criteria, it will reroute the user based on their access level:

  • Non-Inbound Ops Team Users - /queue
  • Inbound Ops Team Users - /queue/correspondence
  • Inbound Ops Team Supervisors and Superusers - /queue/correspondence/team

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to the Correspondence Cases Queue as a Supervisor
  2. Open a correspondence from each of the different tabs, minus any extraneous url data to get to the appropriate correspondence details page:
    1. Unassigned or Assigned - These will REROUTE back to the Correspondence Cases page
    2. Pending or Completed - These will LOAD the Correspondence Details page appropriately
    3. Action Required - Currently don't have easy copyable links
  3. Go to the Your Correspondences page as an Inbound Ops Team user with cases
  4. Open a correspondence from each tab, minus any extraneous url data to get to the appropriate correspondence details page:
    1. Assigned or In Progress - These will REROUTE back to Your Correspondence
    2. Completed - These will LOAD the Correspondence Details page appropriately.

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

@KiMauVA KiMauVA marked this pull request as ready for review September 5, 2024 20:22
@cacevesva cacevesva merged commit 30ab416 into feature/APPEALS-34965 Sep 6, 2024
16 of 17 checks passed
@HunJerBAH HunJerBAH deleted the Ki/APPEALS-51359 branch September 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants