Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87408: Add fallback for debt total monthly net income #17475

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Jul 10, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

We found out that nil values were slipping through for "total monthly net income" property for the transform. This adds fallback 0.00 values for the instances of it.

  • This work is behind a feature toggle (flipper): YES
  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Testing done

Covered by existing tests

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

digitaldrk
digitaldrk previously approved these changes Jul 10, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 87408-form-5655-handle-nil-total-income/main/main July 10, 2024 22:20 Inactive
@maxx1128 maxx1128 force-pushed the 87408-form-5655-handle-nil-total-income branch from e8fdde0 to 27972e3 Compare July 11, 2024 18:20
@va-vfs-bot va-vfs-bot temporarily deployed to 87408-form-5655-handle-nil-total-income/main/main July 11, 2024 18:38 Inactive
@maxx1128 maxx1128 merged commit 145ec37 into master Jul 12, 2024
19 checks passed
@maxx1128 maxx1128 deleted the 87408-form-5655-handle-nil-total-income branch July 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants