Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

85787 Update confirmation page - form 10-10d #30956

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

michaelclement
Copy link
Contributor

@michaelclement michaelclement commented Jul 22, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to Summary and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Summary

This PR updates the confirmation page copy of form 10-10d.

  • Hides the "Get Help" footer only on the confirmation pages for CHAMPVA forms (information is not accurate for this subset of forms on the confirmation page, but is useful during normal form flow)
  • Updated "what happens next" copy
  • Updated mailing/faxing copy
  • Team: IVC CHAMPVA
  • Flipper: in use

Related issue(s)

Testing done

  • Manual
  • Verified unit tests run and pass

Screenshots

Before After
Desktop Screenshot 2024-07-22 at 12 10 35 Screenshot 2024-07-22 at 12 24 10

What areas of the site does it impact?

IVC form 10-10d (Confirmation page, Get Help footer), IVC form 10-7959c (Get Help footer)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

NA

reiting
reiting previously approved these changes Jul 22, 2024
balexandr
balexandr previously approved these changes Jul 22, 2024
@michaelclement michaelclement marked this pull request as ready for review July 22, 2024 17:41
@michaelclement michaelclement requested a review from a team as a code owner July 22, 2024 17:41
@va-vfs-bot va-vfs-bot temporarily deployed to master/85787-update-confirmation-page-1010d/main July 22, 2024 18:09 Inactive
cloudmagic80
cloudmagic80 previously approved these changes Jul 22, 2024
cloudmagic80
cloudmagic80 previously approved these changes Jul 23, 2024
balexandr
balexandr previously approved these changes Jul 23, 2024
micahchiang
micahchiang previously approved these changes Jul 24, 2024
Copy link
Contributor

@micahchiang micahchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments about web component usage, but not a requirement.

<h2>How to contact us about your CHAMPVA application</h2>
<p>
If you have any questions about your application you can call the
CHAMPVA call center at 800-733-8387. We’re here Monday through Friday,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's relatively common for phone numbers to be clickable. Should this be a va-telephone component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in this commit - thanks!

<VaLink text="Go to Ask VA" href="https://ask.va.gov/" />
</p>
<br />
<br />
<a className="vads-c-action-link--green" href="https://www.va.gov/">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it isn't part of this PR, but you could make this a va-link-action component if you wanted to 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in this commit - thanks!

@michaelclement michaelclement merged commit 1116bcf into main Jul 24, 2024
68 of 69 checks passed
@michaelclement michaelclement deleted the 85787-update-confirmation-page-1010d branch July 24, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants