-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot not bumping dependencies in npm workspaces / monorepo structure #5226
Comments
I was undecided if I should setup my monorepo using lerna bootstrap or npm workspaces, and dependabot support is an important factor for me, so I took a look at this. I think setting |
@WIStudent wow thanks a lot for looking into this and providing a forked sample. At the end we ended up disabling Dependabot for our repo because it was generating way too much noise, but this actually solves the issue and I really appreciate it. I'll be closing the issue. |
Use root package and set versioning to increase to make npm workspaces work dependabot/dependabot-core#5226
Based on comments in dependabot/dependabot-core#5226 this might be the way to resolve this issue.
Based on comments in dependabot/dependabot-core#5226 this might be the way to resolve this issue.
* fix(dependabot): set explicit versioning-strategy for NPM ecosystem dependabot/dependabot-core#5226 * chore(dependabot): remove no-longer-relevant ignore blocks
### Description Dependabot wasn't making pull requests so trying to get it configured right. Wish I could test and/or validate it somehow but I couldn't find any way. (Found plenty of people asking how, though!) Looking at dependabot/dependabot-core#2178 and dependabot/dependabot-core#5226, I *think* this is the right configuration. Very unfortunate that we can't globmatch (2178).
### Description Dependabot wasn't making pull requests so trying to get it configured right. Wish I could test and/or validate it somehow but I couldn't find any way. (Found plenty of people asking how, though!) Looking at dependabot/dependabot-core#2178 and dependabot/dependabot-core#5226, I *think* this is the right configuration. Very unfortunate that we can't globmatch (2178).
Package ecosystem
npm
Package manager version
npm 8.5.5
Language version
node v16.15.0
Manifest location and content before the Dependabot update
Monorepo structure:
dependabot.yml content
https://github.com/dreamorosi/test-dependabot-issue/blob/main/.github/dependabot.yml#L25-L32
Updated dependency
https://github.com/dreamorosi/test-dependabot-issue/pull/1
https://github.com/dreamorosi/test-dependabot-issue/pull/2
https://github.com/dreamorosi/test-dependabot-issue/pull/3
https://github.com/dreamorosi/test-dependabot-issue/pull/4
https://github.com/dreamorosi/test-dependabot-issue/pull/5
https://github.com/dreamorosi/test-dependabot-issue/pull/6
What you expected to see, versus what you actually saw
Dependencies being bumped as they should instead of dependabot not updating anything.
Native package manager behavior
N/A
But these dependencies were added by
npm i [package-name] -w packages/a
using npm workspaces commands.Images of the diff or a link to the PR, issue, or logs
See links above
🕹 Bonus points: Smallest manifest that reproduces the issue
This is a minimal reproduction repo that shows the issue. There's no actual code only the
.github/depdendabot.yml
, folder structure, and respectivepackage.json
*package-lock.json
files:https://github.com/dreamorosi/test-dependabot-issue
The text was updated successfully, but these errors were encountered: